[PATCH v13 3/6] CPM/QE: use genalloc to manage CPM/QE muram
christophe.leroy at c-s.fr
Tue Aug 9 03:49:52 AEST 2016
Le 08/08/2016 à 05:00, Qiang Zhao a écrit :
> On 6/8/2016 03:48AM, Christophe Leroy <christophe.leroy at c-s.fr> wrote :
>> -----Original Message-----
>> From: Christophe Leroy [mailto:christophe.leroy at c-s.fr]
>> Sent: Saturday, August 06, 2016 12:59 AM
>> To: Zhao Qiang <qiang.zhao at freescale.com>; lauraa at codeaurora.org
>> Cc: catalin.marinas at arm.com; linux-kernel at vger.kernel.org; Scott Wood
>> <oss at buserror.net>; olof at lixom.net; akpm at linux-foundation.org; linuxppc-
>> dev at lists.ozlabs.org; X.xie at freescale.com
>> Subject: Re: [PATCH v13 3/6] CPM/QE: use genalloc to manage CPM/QE muram
>> Le 30/11/2015 à 03:48, Zhao Qiang a écrit :
>>> Use genalloc to manage CPM/QE muram instead of rheap.
>>> Signed-off-by: Zhao Qiang <qiang.zhao at freescale.com>
>>> Changes for v9:
>>> - splitted from patch 3/5, modify cpm muram management functions.
>>> Changes for v10:
>>> - modify cpm muram first, then move to qe_common
>>> - modify commit.
>>> Changes for v11:
>>> - factor out the common alloc code
>>> - modify min_alloc_order to zero for cpm_muram_alloc_fixed.
>>> Changes for v12:
>>> - Nil
>>> Changes for v13:
>>> - rebase
>>> arch/powerpc/include/asm/cpm.h | 3 +
>>> arch/powerpc/platforms/Kconfig | 4 +-
>>> arch/powerpc/sysdev/cpm_common.c | 126
>>> lib/genalloc.c | 2 +-
>>> 4 files changed, 94 insertions(+), 41 deletions(-)
>> With that patch applied, I get the following Oops on a 8xx (Which has a CPM1).
>> cpm_muram_init() is called from setup_arch()
>> It seems that gen_pool_add() tries to kmalloc() memory but the SLAB is not
>> available yet.
> Thank you for your comments, I can't find a 8xx board, would you like to test the patch
> Attached on your board?
Thanks for your support (indeed I only received your mail a few minutes,
that is after I proposed another patch).
Your patch will not work, because initcalls are called too late. The 8xx
needs the SMCs from the CPM for console, that is long before initcalls
I sent a proposed patch approximatly 2 hours ago, it is called "[PATCH]
soc: fsl/qe: fix Oops on CPM1 (and likely CPM2)"
That one works. Could you have a look ?
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
More information about the Linuxppc-dev