[5.3] ucc_geth: Fix to avoid IS_ERR_VALUE abuses and dead code on 64bit systems.
arnd at arndb.de
Tue Aug 9 01:13:02 AEST 2016
On Monday, August 8, 2016 2:49:11 PM CEST David Laight wrote:
> > If qe_muram_alloc will return any error, Then IS_ERR_VALUE will always
> > return 0. it'll not call ucc_fast_free for any failure. Inside 'if code'
> > will be a dead code on 64bit. Even qe_muram_addr will return wrong
> > virtual address. Which can cause an error.
> > kfree((void *)ugeth->tx_bd_ring_offset[i]);
> Erm, kfree() isn't the right function for things allocated by qe_muram_alloc().
> I still thing you need to stop this code using IS_ERR_VALUE() at all.
Those are two separate issues:
a) The ucc_geth driver mixing kmalloc() memory with muram, and assigning
the result to "u32" and "void __iomem *" variables, both of which
are wrong at least half of the time.
b) calling conventions of qe_muram_alloc() being defined in a way that
requires the use of IS_ERR_VALUE(), because '0' is a valid address
The first one can be solved by updating the network driver, ideally
by getting rid of the casts and using proper types and accessors,
while the second would require updating all users of that interface.
More information about the Linuxppc-dev