[patch] powerpc/fsl_rio: fix a missing error code

[Andrew Morton]

On Thu, 4 Aug 2016 08:35:25 +0300 Dan Carpenter <dan.carpenter at oracle.com> wrote:

> We should set the error code here.  Otherwise static checkers complain.
> 

hm.

> --- a/arch/powerpc/sysdev/fsl_rio.c
> +++ b/arch/powerpc/sysdev/fsl_rio.c
> @@ -491,6 +491,7 @@ int fsl_rio_setup(struct platform_device *dev)
>  	rmu_node = of_parse_phandle(dev->dev.of_node, "fsl,srio-rmu-handle", 0);
>  	if (!rmu_node) {
>  		dev_err(&dev->dev, "No valid fsl,srio-rmu-handle property\n");
> +		rc = -ENOENT;
>  		goto err_rmu;
>  	}
>  	rc = of_address_to_resource(rmu_node, 0, &rmu_regs);

afaict the function will return 0 in this case, which is a flat out
bug.  But why do static checkers complain?  The code will return a
suitably initialized value?

IOW, please always quote the checker/compiler output when fixing a bug!