[PATCH 0311/1285] Replace numeric parameter like 0444 with macro

Baole Ni baolex.ni at intel.com
Tue Aug 2 20:59:03 AEST 2016

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu at intel.com>
Signed-off-by: Baole Ni <baolex.ni at intel.com>
 drivers/macintosh/adbhid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/macintosh/adbhid.c b/drivers/macintosh/adbhid.c
index 09d72bb..d6cbd1d 100644
--- a/drivers/macintosh/adbhid.c
+++ b/drivers/macintosh/adbhid.c
@@ -53,7 +53,7 @@
 MODULE_AUTHOR("Franz Sirl <Franz.Sirl-kernel at lauterbach.com>");
 static int restore_capslock_events;
-module_param(restore_capslock_events, int, 0644);
+module_param(restore_capslock_events, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 	"Produce keypress events for capslock on both keyup and keydown.");

More information about the Linuxppc-dev mailing list