[PATCH 2/9] powerpc/powernv: Use CPU-endian hub diag-data type in pnv_eeh_get_and_dump_hub_diag()
Russell Currey
ruscur at russell.cc
Tue Aug 2 14:33:05 AEST 2016
On Tue, 2016-08-02 at 14:10 +1000, Gavin Shan wrote:
> The hub diag-data type is filled with big-endian data by OPAL call
> opal_pci_get_hub_diag_data(). We need convert it to CPU-endian value
> before using it. The issue is reported by sparse as pointed by Michael
> Ellerman:
>
> gwshan at gwshan:~/sandbox/l$ make C=2 CF=-D__CHECK_ENDIAN__ \
> arch/powerpc/platforms/powernv/eeh-powernv.o
> :
> arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \
> warning: restricted __be16 degrades to integer
> arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \
> warning: restricted __be16 degrades to integer
> arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \
> warning: restricted __be16 degrades to integer
> arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \
> warning: restricted __be16 degrades to integer
> arch/powerpc/platforms/powernv/eeh-powernv.c:1309:21: \
> warning: restricted __be16 degrades to integer
>
> This converts hub diag-data type to CPU-endian before using it in
> pnv_eeh_get_and_dump_hub_diag().
>
> Fixes: 2a485ad7c88d ("powerpc/powernv: Drop PHB operation next_error()")
> Cc: stable at vger.kernel.org # v4.1+
> Suggested-by: Michael Ellerman <mpe at ellerman.id.au>
> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> ---
Reviewed-by: Russell Currey <ruscur at russell.cc>
More information about the Linuxppc-dev
mailing list