[PATCH 1/2] powerpc/85xx: adapt QorIQ eSDHC to the new clocking model

[Scott Wood]

On 04/26/2016 01:29 AM, Yangbo Lu wrote:
> 
> 
>> -----Original Message-----
>> From: Yangbo Lu
>> Sent: Tuesday, April 26, 2016 2:19 PM
>> To: 'Scott Wood'; linux-mmc at vger.kernel.org; linuxppc-
>> dev at lists.ozlabs.org; devicetree at vger.kernel.org
>> Cc: ulf.hansson at linaro.org; Rob Herring; Scott Wood
>> Subject: RE: [PATCH 1/2] powerpc/85xx: adapt QorIQ eSDHC to the new
>> clocking model
>>
>>> -----Original Message-----
>>> From: Scott Wood [mailto:oss at buserror.net]
>>> Sent: Friday, April 22, 2016 7:08 AM
>>> To: Yangbo Lu; linux-mmc at vger.kernel.org;
>>> linuxppc-dev at lists.ozlabs.org; devicetree at vger.kernel.org
>>> Cc: ulf.hansson at linaro.org; Rob Herring; Scott Wood
>>> Subject: Re: [PATCH 1/2] powerpc/85xx: adapt QorIQ eSDHC to the new
>>> clocking model
>>>
>>> On Wed, 2016-04-20 at 18:20 +0800, Yangbo Lu wrote:
>>>> Provide clocks property instead of clock-frequency for QorIQ eSDHC
>>>> dts node to adapt to the new clocking model, so that the driver
>>>> could get clock value by the common clk API and the u-boot could
>>>> remove the clock fixup.
>>>>
>>>> Signed-off-by: Yangbo Lu <yangbo.lu at nxp.com>
>>>> ---
>>>>  arch/powerpc/boot/dts/fsl/qoriq-esdhc-0.dtsi | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/powerpc/boot/dts/fsl/qoriq-esdhc-0.dtsi
>>>> b/arch/powerpc/boot/dts/fsl/qoriq-esdhc-0.dtsi
>>>> index 20835ae..ddbe562 100644
>>>> --- a/arch/powerpc/boot/dts/fsl/qoriq-esdhc-0.dtsi
>>>> +++ b/arch/powerpc/boot/dts/fsl/qoriq-esdhc-0.dtsi
>>>> @@ -36,5 +36,5 @@ sdhc: sdhc at 114000 {
>>>>  	compatible = "fsl,esdhc";
>>>>  	reg = <0x114000 0x1000>;
>>>>  	interrupts = <48 2 0 0>;
>>>> -	clock-frequency = <0>;
>>>> +	clocks = <&clockgen 4 1>;
>>>>  };
>>>
>>> Binding update?
>>>
>>> -Scott
>>
>> [Lu Yangbo-B47093] Sorry, did you mean the doc update? ...
>> It has already had a description in
>> Documentation/devicetree/bindings/clock/qoriq-clock.txt
>>
>> - clock-frequency: Input system clock frequency (SYSCLK)
>> - clocks: If clock-frequency is not specified, sysclk may be provided
>>         as an input clock.  Either clock-frequency or clocks must be
>>         provided.
> 
> [Lu Yangbo-B47093] Or update mmc doc?

Yes, mmc.  This patch has nothing to do with the clockgen node's input
clock...

-Scott