[PATCH v2 3/5] powerpc/dts: add a compatible string to gpio0

[Chenhui Zhao]

Thank you for your comment. I'll change it according to the GPIO binding document.

Thanks,
Chenhui

________________________________________
From: Yang-Leo Li
Sent: Saturday, April 16, 2016 12:47 AM
To: Chenhui Zhao; linuxppc-dev at lists.ozlabs.org; oss at buserror.net
Cc: Chenhui Zhao; Zhengxiong Jin
Subject: RE: [PATCH v2 3/5] powerpc/dts: add a compatible       string to gpio0

> -----Original Message-----
> From: linuxppc-release-bounces at linux.freescale.net [mailto:linuxppc-release-
> bounces at linux.freescale.net] On Behalf Of Chenhui Zhao
> Sent: Friday, April 15, 2016 6:13 AM
> To: linuxppc-dev at lists.ozlabs.org; oss at buserror.net
> Cc: Chenhui Zhao <chenhui.zhao at nxp.com>; Zhengxiong Jin
> <jason.jin at nxp.com>
> Subject: [linuxppc-release] [PATCH v2 3/5] powerpc/dts: add a compatible string
> to gpio0
>
> All gpio nodes used the same compatible string "fsl,qoriq-gpio".
> To identify the node corresponding to the GPIO1 pins, add a compatible string
> "fsl,qoriq-gpio-1".

This is not a documented binding.  And we normally don't add compatible strings for this purpose.  If you want to reference a specific GPIO pin, use the binding described at Documentation/devicetree/bindings/gpio/gpio.txt

Regards,
Leo

>
> Signed-off-by: Chenhui Zhao <chenhui.zhao at nxp.com>
> ---
>  arch/powerpc/boot/dts/fsl/qoriq-gpio-0.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/boot/dts/fsl/qoriq-gpio-0.dtsi
> b/arch/powerpc/boot/dts/fsl/qoriq-gpio-0.dtsi
> index cf714f5..1a26d6b 100644
> --- a/arch/powerpc/boot/dts/fsl/qoriq-gpio-0.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/qoriq-gpio-0.dtsi
> @@ -33,7 +33,7 @@
>   */
>
>  gpio0: gpio at 130000 {
> -     compatible = "fsl,qoriq-gpio";
> +     compatible = "fsl,qoriq-gpio-1", "fsl,qoriq-gpio";
>       reg = <0x130000 0x1000>;
>       interrupts = <55 2 0 0>;
>       #gpio-cells = <2>;
> --
> 1.9.1
>
> _______________________________________________
> linuxppc-release mailing list
> linuxppc-release at linux.freescale.net
> http://linux.freescale.net/mailman/listinfo/linuxppc-release