[PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0

[Yang-Leo Li]

> -----Original Message-----
> From: Brian Norris [mailto:computersforpeace at gmail.com]
> Sent: Wednesday, April 06, 2016 12:53 PM
> To: Li Yang <leoli at freescale.com>
> Cc: Scott Wood <oss at buserror.net>; Raghav Dogra <raghav.dogra at nxp.com>;
> linux-mtd at lists.infradead.org; linuxppc-dev <linuxppc-dev at lists.ozlabs.org>;
> Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; Raghav Dogra
> <raghav at freescale.com>; Jaiprakash Singh <b44839 at freescale.com>; Boris
> Brezillon <boris.brezillon at free-electrons.com>
> Subject: Re: [PATCH][v3] mtd/ifc: Add support for IFC controller version 2.0
> 
> Hi,
> 
> On Wed, Mar 30, 2016 at 03:43:40PM -0500, Li Yang wrote:
> > Hi Brian,
> >
> > Could you help to review and pull in this patch and the Kconfig update
> > after this patch(https://patchwork.ozlabs.org/patch/557389/)?  It
> 
> It's probably best for Boris to apply this now.

Thanks Brian.  I see Boris is taking over the maintenance of NAND recently, we will follow up with him.

Hi Boris,

Can you consider to pull in this patch and then Kconfig patch (https://patchwork.ozlabs.org/patch/557389/)?

Regards,
Leo

> 
> > stated a dependency in the notes, but actually it should be applied
> > cleanly without that patch.  These patches are critical to make NAND
> > mtd feature work for our new chips.
> >
> > Regards,
> > Leo
> >
> > On Thu, Feb 18, 2016 at 6:07 PM, Scott Wood <oss at buserror.net> wrote:
> > > On Thu, 2016-02-18 at 15:18 -0600, Leo Li wrote:
> > >> On Wed, Feb 17, 2016 at 5:24 AM, Raghav Dogra <raghav.dogra at nxp.com>
> wrote:
> > >> > The new IFC controller version 2.0 has a different memory map page.
> > >> > Upto IFC 1.4 PAGE size is 4 KB and from IFC2.0 PAGE size is 64KB.
> > >> > This patch segregates the IFC global and runtime registers to
> > >> > appropriate PAGE sizes.
> > >> >
> > >> > Signed-off-by: Jaiprakash Singh <b44839 at freescale.com>
> > >> > Signed-off-by: Raghav Dogra <raghav at freescale.com>
> > >> > Acked-by: Li Yang <leoyang.li at nxp.com>
> > >> > Signed-off-by: Raghav Dogra <raghav.dogra at nxp.com>
> > >> > ---
> > >> > Changes for v3: not dependent on
> > >> > "drivers/memory: Add deep sleep support for IFC" patch
> > >> >
> > >> > Changes for v2: rebased to resolve conflicts Applicable to
> > >> > git://git.infradead.org/l2-mtd.git
> > >> >
> > >> > This patch is dependent on "drivers/memory: Add deep sleep
> > >> > support for IFC"
> > >> > https://patchwork.ozlabs.org/patch/582762/
> > >> > which is also applicable to git://git.infradead.org/l2-mtd.git
> 
> For the patch:
> 
> Acked-by: Brian Norris <computersforpeace at gmail.com>
> 
> > >> This patch seems to be in good shape, but the dependency is still
> > >> having quite some feedback to be addressed.  Depending on it will
> > >> greatly delay the time that this critical patch for LS2 to be merged.
> > >> Could you remove the dependency like Scott already suggested?
> > >
> > > According to the changelog the dependency has been removed (it would
> > > have been clearer to remove this comment as well...).
> > >
> > > -Scott
> > >
> >
> >
> >
> > --
> > - Leo