[PATCH v4 23/32] cxlflash: Fix function prolog parameters and return codes
Matthew R. Ochs
mrochs at linux.vnet.ibm.com
Wed Sep 30 06:31:28 AEST 2015
> On Sep 28, 2015, at 11:36 PM, Andrew Donnellan <andrew.donnellan at au1.ibm.com> wrote:
> On 26/09/15 09:18, Matthew R. Ochs wrote:
>> static int send_tmf(struct afu *afu, struct scsi_cmnd *scp, u64 tmfcmd)
>> @@ -491,9 +490,7 @@ static const char *cxlflash_driver_info(struct Scsi_Host *host)
>> * @host: SCSI host associated with device.
>> * @scp: SCSI command to send.
>> - * Return:
>> - * 0 on success
>> - * SCSI_MLQUEUE_HOST_BUSY when host is busy
>> + * Return: 0 on success or SCSI_MLQUEUE_HOST_BUSY
> I'd prefer it to say "SCSI_MLQUEUE_HOST_BUSY on failure". (Aesthetically I prefer having it on a separate line, but that's just personal preference.)
> As an aside, while checking the correctness of this, I found that the comment for cxlflash_send_cmd() states that it returns -1 on failure, when the only error value it actually returns is SCSI_MLQUEUE_HOST_BUSY. If you send a v5 you might want to fix this.
I'll make a note of this.
More information about the Linuxppc-dev