[PATCH v4 29/32] cxlflash: Fix to double the delay each time
Matthew R. Ochs
mrochs at linux.vnet.ibm.com
Wed Sep 30 06:28:37 AEST 2015
> On Sep 28, 2015, at 8:40 PM, Daniel Axtens <dja at axtens.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> "Matthew R. Ochs" <mrochs at linux.vnet.ibm.com> writes:
>> From: Manoj Kumar <manoj at linux.vnet.ibm.com>
>> The operator used to double the delay is incorrect and
>> does not result in delay doubling.
>> To fix, use a left shift instead of the XOR operator.
> I can see that the patch is correct, but this commit message is a bit
> confusing. What delay? In what circumstances are you doubling it? Why?
This is the response delay while resetting the master context. The reset
is performed by writing a bit and then waiting for it to clear. While waiting
for it to clear, the code relaxes the delta between MMIO reads.
More information about the Linuxppc-dev