[PATCH v4 02/32] cxlflash: Replace magic numbers with literals

Andrew Donnellan andrew.donnellan at au1.ibm.com
Tue Sep 29 15:40:58 AEST 2015

On 26/09/15 09:12, Matthew R. Ochs wrote:
> From: Manoj Kumar <kumarmn at us.ibm.com>
> Magic numbers are not meaningful and can create confusion. As a
> remedy, replace them with descriptive literals.
> Replace 512 with literal MAX_SECTOR_UNIT.
> Replace 5 with literal CMD_RETRIES.
> Signed-off-by: Matthew R. Ochs <mrochs at linux.vnet.ibm.com>
> Signed-off-by: Manoj N. Kumar <manoj at linux.vnet.ibm.com>
> Reviewed-by: Brian King <brking at linux.vnet.ibm.com>

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

Andrew Donnellan              Software Engineer, OzLabs
andrew.donnellan at au1.ibm.com  Australia Development Lab, Canberra
+61 2 6201 8874 (work)        IBM Australia Limited

More information about the Linuxppc-dev mailing list