[PATCH v3 1/3] powerpc/512x: add LocalPlus Bus FIFO device driver

Timur Tabi timur at tabi.org
Mon Sep 28 23:18:21 AEST 2015

Alexander Popov wrote:
> The only question I have: why calling dma_unmap_single() from within
> a spinlock is a bad practice?

I don't know, but usually functions that allocate or free memory cannot 
be called from within a spinlock.  You need to check that.  Since the 
MPC5121 is a single-core CPU, you might not notice if you're doing 
something wrong.

More information about the Linuxppc-dev mailing list