[PATCH v3 31/32] cxlflash: Fix to avoid corrupting adapter fops
Matthew R. Ochs
mrochs at linux.vnet.ibm.com
Sat Sep 26 08:35:55 AEST 2015
> On Sep 25, 2015, at 4:23 PM, Brian King <brking at linux.vnet.ibm.com> wrote:
> On 09/24/2015 02:44 PM, Matthew R. Ochs wrote:
>> @@ -1293,8 +1291,8 @@ static int cxlflash_disk_attach(struct scsi_device *sdev,
>> int fd = -1;
>> - /* On first attach set fileops */
>> - if (atomic_read(&cfg->num_user_contexts) == 0)
>> + /* On very first attach set fileops for adapter */
>> + if (cfg->cxl_fops.owner != THIS_MODULE)
>> cfg->cxl_fops = cxlflash_cxl_fops;
> Hmm... Why not just set this up once at probe time instead?
I tried to explain this in the commit message. I left it out of probe
time in an attempt to keep it separate from the legacy support as
it's only needed for superpipe.
I'll fix up this commit and just move it to probe as that seems easiest.
More information about the Linuxppc-dev