[PATCH v3 1/2] fsl: Add binding for RCPM

[Wang Dongsheng]

Hi Shawn,

Thanks for your review.

> > From: Wang Dongsheng <dongsheng.wang at freescale.com>
> >
> > RCPM is the Run Control and Power Management module performs all
> > device-level tasks associated with device run control and power
> > management.
> >
> > Add this for freescale powerpc platform and layerscape platform.
> >
> > Signed-off-by: Chenhui Zhao <chenhui.zhao at freescale.com>
> > Signed-off-by: Tang Yuantian <Yuantian.Tang at freescale.com>
> > Signed-off-by: Wang Dongsheng <dongsheng.wang at freescale.com>
> > ---
> > *v3*
> > - Add "fsl,#rcpm-wakeup-cells" for rcpm node. The number of cells
> >   correspond rcpm-wakeup property.
> > - Modify rcpm-wakeup property description.
> >
> > *v2*
> > - Remove P4080 example.
> > - Modify rcpm-wakeup property description.
> >
> > diff --git a/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > new file mode 100644
> > index 0000000..52110ec
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/fsl/rcpm.txt
> > @@ -0,0 +1,63 @@
> > +* Run Control and Power Management
> > +-------------------------------------------
> > +The RCPM performs all device-level tasks associated with device run
> > +control and power management.
> > +
> > +Required properites:
> > +  - reg : Offset and length of the register set of RCPM block.
> > +  - fsl,#rcpm-wakeup-cells : The number of cells in rcpm-wakeup property.
> > +  - compatible : Sould contain a chip-specific RCPM block compatible string
> > +	and (if applicable) may contain a chassis-version RCPM compatible
> > +	string. Chip-specific strings are of the form "fsl,<chip>-rcpm",
> > +	such as:
> > +	* "fsl,p2041-rcpm"
> > +	* "fsl,p3041-rcpm"
> > +	* "fsl,p4080-rcpm"
> > +	* "fsl,p5020-rcpm"
> > +	* "fsl,p5040-rcpm"
> > +	* "fsl,t4240-rcpm"
> > +	* "fsl,b4420-rcpm"
> > +	* "fsl,b4860-rcpm"
> > +
> > +	Chassis-version strings are of the form "fsl,qoriq-rcpm-<version>",
> > +	such as:
> > +	* "fsl,qoriq-rcpm-1.0": for chassis 1.0 rcpm
> > +	* "fsl,qoriq-rcpm-2.0": for chassis 2.0 rcpm
> > +	* "fsl,qoriq-rcpm-2.1": for chassis 2.1 rcpm
> > +
> > +All references to "1.0" and "2.0" refer to the QorIQ chassis version
> > +to which the chip complies.
> > +Chassis Version		Example Chips
> > +---------------		-------------------------------
> > +1.0				p4080, p5020, p5040, p2041, p3041
> > +2.0				t4240, b4860, b4420
> > +2.1				t1040, ls1021
> > +
> > +Example:
> > +The RCPM node for T4240:
> > +	rcpm: global-utilities at e2000 {
> > +		compatible = "fsl,t4240-rcpm", "fsl,qoriq-rcpm-2.0";
> > +		reg = <0xe2000 0x1000>;
> > +		fsl,#rcpm-wakeup-cells = <2>;
> > +	};
> > +
> > +* Freescale RCPM Wakeup Source Device Tree Bindings
> > +-------------------------------------------
> > +Required rcpm-wakeup property should be added to a device node if the
> > +device can be used as a wakeup source.
> > +
> > +  - rcpm-wakeup: The value of the property consists of cells, the
> > + number of
> 
> Shouldn't this vendor specific property be prefixed with 'fsl,' as well?
> 

Okay.

> > +	cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a pointer
> > +	to the rcpm node, the second cell is the bit mask that should be set
> > +	in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on.
> 
> I guess that IPPDEXPCR0 and IPPDEXPCR1 need some documentation too, or a pointer
> to hardware documents containing more detailed info about them.
> 

Following the "rcpm-wakeup" documents put a "Note" to describe IPPDEXPCRx registers?

Regards,
-Dongsheng