[PATCH] powerpc: fsl_pci: cast the regs->nip to void * when passing it to probe_kernel_address()

Michael Ellerman mpe at ellerman.id.au
Tue Sep 22 15:17:01 AEST 2015


On Mon, 2015-09-21 at 21:16 -0500, Scott Wood wrote:
> On Mon, 2015-09-21 at 17:22 +0800, Kevin Hao wrote:
> > With the reimplementation of probe_kernel_address() in commit
> > ecc83243e1d4 ("uaccess: reimplement probe_kernel_address() using
> > probe_kernel_read()"), the explication of the cast for the addr
> > parameter has been dropped. So we have to explicitly cast the
> > regs->nip to void * when passing it to probe_kernel_address() in
> > order to fix the following build error:
> >   arch/powerpc/sysdev/fsl_pci.c: In function 'fsl_pci_mcheck_exception':
> >   arch/powerpc/sysdev/fsl_pci.c:1002:4: error: passing argument 2 of 
> > 'probe_kernel_read' makes pointer from integer without a cast [-Werror]
> >       ret = probe_kernel_address(regs->nip, inst);
> >       ^
> > 
> > Signed-off-by: Kevin Hao <haokexin at gmail.com>
> > ---
> > 
> > This is against linux-next.
> 
> I don't see ecc83243e1d4 in linux-next.  What tree is it in?

It was in linux-next:

  commit ecc83243e1d4f67015906017e420435aff1104c9
  Author:     Andrew Morton <akpm at linux-foundation.org>
  AuthorDate: Thu Sep 17 10:19:09 2015 +1000
  Commit:     Stephen Rothwell <sfr at canb.auug.org.au>
  CommitDate: Thu Sep 17 10:19:09 2015 +1000

      uaccess: reimplement probe_kernel_address() using probe_kernel_read()


But Andrew's tree comes as patches that Stephen commits, so the commit ids
change when Andrew pushes new patches, so in today's linux-next it's:


  commit d2cf644bea102203f9fc221a819f2dcb6a15b8ad
  Author:     Andrew Morton <akpm at linux-foundation.org>
  AuthorDate: Sat Sep 19 11:36:21 2015 +1000
  Commit:     Stephen Rothwell <sfr at canb.auug.org.au>
  CommitDate: Sat Sep 19 11:36:21 2015 +1000

      uaccess: reimplement probe_kernel_address() using probe_kernel_read()


cheers




More information about the Linuxppc-dev mailing list