[PATCH] powerpc: fsl_pci: cast the regs->nip to void * when passing it to probe_kernel_address()

Michael Ellerman mpe at ellerman.id.au
Tue Sep 22 12:08:17 AEST 2015


On Mon, 2015-09-21 at 17:22 +0800, Kevin Hao wrote:
> With the reimplementation of probe_kernel_address() in commit
> ecc83243e1d4 ("uaccess: reimplement probe_kernel_address() using
> probe_kernel_read()"), the explication of the cast for the addr
> parameter has been dropped. So we have to explicitly cast the
> regs->nip to void * when passing it to probe_kernel_address() in
> order to fix the following build error:
>   arch/powerpc/sysdev/fsl_pci.c: In function 'fsl_pci_mcheck_exception':
>   arch/powerpc/sysdev/fsl_pci.c:1002:4: error: passing argument 2 of 'probe_kernel_read' makes pointer from integer without a cast [-Werror]
>       ret = probe_kernel_address(regs->nip, inst);
>       ^
> 
> Signed-off-by: Kevin Hao <haokexin at gmail.com>
> ---
> 
> This is against linux-next.

You should be sending this to Andrew Morton, the author of the patch that
caused the breakage. Or at the very least CC'ing him.

cheers




More information about the Linuxppc-dev mailing list