[PATCH v2 04/30] cxlflash: Fix potential oops following LUN removal

Matthew R. Ochs mrochs at linux.vnet.ibm.com
Sat Sep 19 09:18:24 AEST 2015


> On Sep 17, 2015, at 8:26 PM, Brian King <brking at linux.vnet.ibm.com> wrote:
> 
> On 09/16/2015 04:27 PM, Matthew R. Ochs wrote:
>> 
>> 	lun_access = kzalloc(sizeof(*lun_access), GFP_KERNEL);
>> 	if (unlikely(!lun_access)) {
>> 		dev_err(dev, "%s: Unable to allocate lun_access!\n", __func__);
>> +		scsi_device_put(sdev);
> 
> Looks like you've got a double scsi_device_put in this path, since there is another put
> in the the err0 path.

Good catch! I'll fix in v3.



More information about the Linuxppc-dev mailing list