[PATCH] powerpc: mpc512x: drop bogus and unused psc register bit definitions

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Fri Sep 18 16:36:18 AEST 2015


Hello,

On Tue, Jul 21, 2015 at 09:21:13AM +0200, Uwe Kleine-König wrote:
> These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add
> MPC512x PSC support to MPC52xx psc driver") and never used. Moreover
> according to the datasheet[1] MEMERROR is bit 25 (0x40) and ORERR is
> bit 27 (0x10).
> 
> [1] MPC5125RM Rev. 2; 11/2009

I didn't get any feedback for this patch yet. Do you still consider it?

Best regards
Uwe

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>  arch/powerpc/include/asm/mpc52xx_psc.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/mpc52xx_psc.h b/arch/powerpc/include/asm/mpc52xx_psc.h
> index d0ece257d310..92806c24c2c5 100644
> --- a/arch/powerpc/include/asm/mpc52xx_psc.h
> +++ b/arch/powerpc/include/asm/mpc52xx_psc.h
> @@ -258,8 +258,6 @@ struct mpc52xx_psc_fifo {
>  #define MPC512x_PSC_FIFO_FULL		0x2
>  #define MPC512x_PSC_FIFO_ALARM		0x4
>  #define MPC512x_PSC_FIFO_URERR		0x8
> -#define MPC512x_PSC_FIFO_ORERR		0x01
> -#define MPC512x_PSC_FIFO_MEMERROR	0x02
>  
>  struct mpc512x_psc_fifo {
>  	u32		reserved1[10];

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |


More information about the Linuxppc-dev mailing list