[PATCH] powerpc/eeh: eeh_pci_enable(): fix checking of post-request state

Daniel Axtens dja at axtens.net
Tue Oct 27 10:05:28 AEDT 2015


Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:


> diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
> index 40e4d4a..d757e7c 100644
> --- a/arch/powerpc/kernel/eeh.c
> +++ b/arch/powerpc/kernel/eeh.c
> @@ -677,7 +677,7 @@ int eeh_pci_enable(struct eeh_pe *pe, int function)
>  	/* Check if the request is finished successfully */
>  	if (active_flag) {
>  		rc = eeh_ops->wait_state(pe, PCI_BUS_RESET_WAIT_MSEC);
> -		if (rc <= 0)
> +		if (rc < 0)
>  			return rc;
>  
>  		if (rc & active_flag)


Reviewed-by: Daniel Axtens <dja at axtens.net>


> -- 
> Andrew Donnellan              Software Engineer, OzLabs
> andrew.donnellan at au1.ibm.com  Australia Development Lab, Canberra
> +61 2 6201 8874 (work)        IBM Australia Limited
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20151027/165fb4b3/attachment.sig>


More information about the Linuxppc-dev mailing list