[PATCH 04/17] powerpc: mpic: use IRQCHIP_SKIP_SET_WAKE instead of redundant mpic_irq_set_wake

Scott Wood scottwood at freescale.com
Tue Oct 20 04:46:09 AEDT 2015


On Mon, 2015-10-19 at 18:35 +0100, Sudeep Holla wrote:
> Hi Ben,
> 
> On 23/09/15 05:06, Scott Wood wrote:
> > On Mon, 2015-09-21 at 16:47 +0100, Sudeep Holla wrote:
> > > mpic_irq_set_wake return -ENXIO for non FSL MPIC and sets 
> > > IRQF_NO_SUSPEND
> > > flag for FSL ones. enable_irq_wake already returns -ENXIO if irq_set_wak
> > > is not implemented. Also there's no need to set the IRQF_NO_SUSPEND flag
> > > as it doesn't guarantee wakeup for that interrupt.
> > > 
> > > This patch removes the redundant mpic_irq_set_wake and sets the
> > > IRQCHIP_SKIP_SET_WAKE for only FSL MPIC.
> > > 
> > > Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> > > Cc: Paul Mackerras <paulus at samba.org>
> > > Cc: Michael Ellerman <mpe at ellerman.id.au>
> > > Cc: Scott Wood <scottwood at freescale.com>
> > > Cc: Hongtao Jia <hongtao.jia at freescale.com>
> > > Cc: Marc Zyngier <marc.zyngier at arm.com>
> > > Cc: linuxppc-dev at lists.ozlabs.org
> > > Signed-off-by: Sudeep Holla <sudeep.holla at arm.com>
> > > ---
> > >   arch/powerpc/sysdev/mpic.c | 23 ++++-------------------
> > >   1 file changed, 4 insertions(+), 19 deletions(-)
> > 
> > Acked-by: Scott Wood <scottwood at freescale.com>
> > 
> 
> Can you pick this up via your tree ?

OK.

-Scott



More information about the Linuxppc-dev mailing list