[PATCH v2] powerpc/prom: Avoid reference to potentially freed memory
Michael Ellerman
mpe at ellerman.id.au
Mon Oct 19 20:27:57 AEDT 2015
On Fri, 2015-10-16 at 23:38 +0200, Christophe JAILLET wrote:
> of_get_property() is used inside the loop, but then the reference to the
> node is dropped before dereferencing the prop pointer, which could by then
> point to junk if the node has been freed.
>
> Instead use of_property_read_u32() to actually read the property
> value before dropping the reference.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet at wanadoo.fr>
> ---
> v2: Fix missing '{'
> *** COMPILE-TESTED ONLY ***
Thanks, this looks good. I'll test it on real hardware.
Can you send me a follow up which does the of_get_next_parent() conversion?
cheers
More information about the Linuxppc-dev
mailing list