[PATCH 1/2] powerpc/fsl: Add PCI node in device tree of bsc9132qds

Hou Zhiqiang B48286 at freescale.com
Thu Oct 15 13:52:58 AEDT 2015



> -----Original Message-----
> From: Wood Scott-B07421
> Sent: 2015年10月15日 4:36
> To: Hou Zhiqiang-B48286
> Cc: linuxppc-dev at lists.ozlabs.org; galak at kernel.crashing.org;
> benh at kernel.crashing.org; paulus at samba.org; mpe at ellerman.id.au;
> devicetree at vger.kernel.org; robh+dt at kernel.org; pawel.moll at arm.com;
> mark.rutland at arm.com; ijc+devicetree at hellion.org.uk; Rai Harninder-B01044;
> Lian Minghuan-B31939; Hu Mingkai-B21284
> Subject: Re: [PATCH 1/2] powerpc/fsl: Add PCI node in device tree of
> bsc9132qds
> 
> On Tue, 2015-10-13 at 19:29 +0800, Zhiqiang Hou wrote:
> > From: Harninder Rai <harninder.rai at freescale.com>
> >
> > Signed-off-by: Harninder Rai <harninder.rai at freescale.com>
> > Signed-off-by: Minghuan Lian <Minghuan.Lian at freescale.com>
> > Change-Id: I4355add4a92d1fcf514843aea5ecadd2e2517969
> > Reviewed-on: http://git.am.freescale.net:8181/2454
> > Reviewed-by: Zang Tiefei-R61911 <tie-fei.zang at freescale.com>
> > Reviewed-by: Kushwaha Prabhakar-B32579 <prabhakar at freescale.com>
> > Reviewed-by: Fleming Andrew-AFLEMING <AFLEMING at freescale.com>
> > Tested-by: Fleming Andrew-AFLEMING <AFLEMING at freescale.com>
> 
> Get rid of the gerrit stuff.  And where is your signoff?
> 
> > diff --git a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > index c723071..78c8f1c 100644
> > --- a/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi
> > @@ -40,6 +40,35 @@
> >       interrupts = <16 2 0 0 20 2 0 0>;  };
> >
> > +/* controller at 0xa000 */
> > +&pci0 {
> > +     compatible = "fsl,bsc9132-pcie", "fsl,qoriq-pcie-v2.2";
> > +     device_type = "pci";
> > +     #size-cells = <2>;
> > +     #address-cells = <3>;
> > +     bus-range = <0 255>;
> > +     clock-frequency = <33333333>;
> > +     interrupts = <16 2 0 0>;
> 
> This clock-frequency is not correct for PCIe.  Just remove it.
> 

Ok, thanks for your correction.
 

Thanks,
Zhiqiang



More information about the Linuxppc-dev mailing list