[PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks
Michael Ellerman
mpe at ellerman.id.au
Wed Oct 7 11:46:38 AEDT 2015
On Wed, 2015-09-30 at 16:45 -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 30, 2015 at 09:09:09PM +0200, Jiri Olsa escreveu:
> > On Wed, Sep 30, 2015 at 11:28:36AM -0700, Sukadev Bhattiprolu wrote:
> > > From e29aeeee7236122c4d807ec9ebc721b5d7d75c8d Mon Sep 17 00:00:00 2001
> > > From: Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com>
> > > Date: Thu, 24 Sep 2015 17:53:49 -0400
> > > Subject: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks
> > >
> > > perf_regs.c does not get built on Powerpc as CONFIG_PERF_REGS is false.
> > > So the weak definition for 'sample_regs_masks' doesn't get picked up.
> > >
> > > Adding perf_regs.o to util/Build unconditionally, exposes a redefinition
> > > error for 'perf_reg_value()' function (due to the static inline version
> > > in util/perf_regs.h). So use #ifdef HAVE_PERF_REGS_SUPPORT' around that
> > > function.
> > >
> > > Signed-off-by: Sukadev Bhattiprolu <sukadev at linux.vnet.ibm.com>
> >
> > Acked-by: Jiri Olsa <jolsa at kernel.org>
>
> Thanks, applied.
Is this going to Linus' tree any time soon?
I have folks pinging me to say that perf is broken on powerpc.
cheers
More information about the Linuxppc-dev
mailing list