[PATCH] powerpc: Kconfig.cputype: Disallow TUNE_CELL on LE systems

[Michael Ellerman]

On Mon, 2015-09-21 at 12:07 +0200, Thomas Huth wrote:
> On 21/09/15 09:18, Michael Ellerman wrote:
> > On Fri, 2015-09-18 at 16:17 +0200, Thomas Huth wrote:
> >> It looks somewhat weird that you can enable TUNE_CELL on little
> >> endian systems, so let's disable this option with CPU_LITTLE_ENDIAN.
> >>
> >> Signed-off-by: Thomas Huth <thuth at redhat.com>
> >> ---
> >>  I first thought that it might be better to make this option depend
> >>  on PPC_CELL instead ... but I guess it's a bad idea to depend a
> >>  CPU option on a platform option? Alternatively, would it make
> >>  sense to make it depend on (GENERIC_CPU || CELL_CPU) instead?
> > 
> > Hmm, it's a little backward, but I think it would be fine, and less confusing
> > for users. Both PS3 and Cell select PPC_CELL, so it would work in both those
> > cases.
> 
> It's just that when you step through the kernel config (e.g. with "make
> menuconfig"), you normally step through the "Processor support" first,
> and then later do the "Platform support". I think most users won't look
> back into "Processor support" again once they already reached the
> "Platform support" section, so this TUNE_CELL option then might appear
> unnoticed when you enable a Cell platform under "Platform support".

Ah OK. Personally I almost never use menuconfig, but I guess some folks do.

That actually seems like we should reorder those sections, ie. put platform
support first, and then processor support. After all there's not much point
agonising over whether to tune for CELL cpus if you then don't enable a Cell
platform.

I'm not sure if it's that simple in practice ... :)

cheers