[PATCH v5 18/34] cxlflash: Fix AFU version access/storage and add check

Daniel Axtens dja at axtens.net
Fri Oct 2 14:17:01 AEST 2015


"Matthew R. Ochs" <mrochs at linux.vnet.ibm.com> writes:

> Correct, downlevel (unsupported) AFUs don't implement the interface_version
> register and thus will return -1 at that offset.
Cool. It would be good to document that somewhere, either the comment or
the commit message, but it's not worth holding up the series for it.

I also tend to use the form (var == ~0ULL) for tests like this but
that's an aesthetic thing.

Reviewed-by: Daniel Axtens <dja at axtens.net>

Regards,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20151002/5dd5683e/attachment.sig>


More information about the Linuxppc-dev mailing list