[PATCH 1/4] powerpc/powernv: panic() on OPAL < V3

Stewart Smith stewart at linux.vnet.ibm.com
Fri Nov 27 16:43:26 AEDT 2015


Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
>> --- a/arch/powerpc/platforms/powernv/opal.c
>> +++ b/arch/powerpc/platforms/powernv/opal.c
>> @@ -103,11 +103,8 @@ int __init early_init_dt_scan_opal(unsigned long node,
>>   		powerpc_firmware_features |= FW_FEATURE_OPALv2;
>>   		powerpc_firmware_features |= FW_FEATURE_OPALv3;
>>   		pr_info("OPAL V3 detected !\n");
>> -	} else if (of_flat_dt_is_compatible(node, "ibm,opal-v2")) {
>> -		powerpc_firmware_features |= FW_FEATURE_OPALv2;
>> -		pr_info("OPAL V2 detected !\n");
>>   	} else {
>> -		pr_info("OPAL V1 detected !\n");
>> +		panic("OPAL != V3 detected, no longer supported.\n")
>
> In the event of an OPAL v4 that is for some reason not backwards 
> compatible with V3, "*no longer* supported" might not make sense. This 
> isn't a huge problem of course.

Considering you need kernel support for any new POWER processor, and we're not
about to do an OPALv4 on POWER8 or earlier - we're going to be safe :)



More information about the Linuxppc-dev mailing list