cxl: use correct operator when writing pcie config space values

Michael Ellerman mpe at ellerman.id.au
Thu Nov 26 23:15:54 AEDT 2015


On Wed, 2015-04-11 at 02:24:09 UTC, Andrew Donnellan wrote:
> When writing a value to config space, cxl_pcie_write_config() calls
> cxl_pcie_config_info() to obtain a mask and shift value, shifts the new
> value accordingly, then uses the mask to combine the shifted value with the
> existing value at the address as part of a read-modify-write pattern.
> 
> Currently, we use a logical OR operator rather than a bitwise OR operator,
> which means any use of this function results in an incorrect value being
> written. Replace the logical OR operator with a bitwise OR operator so the
> value is written correctly.
> 
> Reported-by: Michael Ellerman <mpe at ellerman.id.au>
> Cc: stable at vger.kernel.org
> Fixes: 6f7f0b3df6d4 ("cxl: Add AFU virtual PHB and kernel API")
> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> Acked-by: Ian Munsie <imunsie at au1.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/48f0f6b717e314a30be121b6

cheers


More information about the Linuxppc-dev mailing list