[PATCH] cpufreq: qoriq: Register cooling device based on device tree

Hongtao Jia hongtao.jia at freescale.com
Wed Nov 25 19:00:02 AEDT 2015



> -----Original Message-----
> From: Viresh Kumar [mailto:viresh.kumar at linaro.org]
> Sent: Tuesday, November 24, 2015 3:11 PM
> To: Jia Hongtao-B38951
> Cc: edubezval at gmail.com; linux-pm at vger.kernel.org; linuxppc-
> dev at lists.ozlabs.org; devicetree at vger.kernel.org; Wood Scott-B07421
> Subject: Re: [PATCH] cpufreq: qoriq: Register cooling device based on
> device tree
> 
> On 24-11-15, 14:55, Jia Hongtao wrote:
> > +	/* Register CPU cooling device for QorIQ platform */
> > +	for_each_node_with_property(cpu_np, "#cooling-cells") {
> > +		of_property_read_u32(cpu_np, "reg", &cpu_id);
> > +		cpufreq_get_policy(&cpu_policy, cpu_id);
> 
> That's not the right way to do it. You already have DT node for the CPU,
> look at how it is done from ->ready() callback for cpufreq-dt.
> 
> --
> viresh

Thanks.

I made a new patch to use ->ready callback for cpu cooling registration.
I will send V2 after test.

-Hongtao.


More information about the Linuxppc-dev mailing list