[PATCH v7 37/50] powerpc/powernv: Simplify pnv_eeh_reset()
Daniel Axtens
dja at axtens.net
Thu Nov 12 16:11:12 AEDT 2015
> - rc = opal_pci_reset(phb->opal_id,
> - OPAL_RESET_PHB_ERROR,
> - OPAL_ASSERT_RESET);
> - if (rc != OPAL_SUCCESS) {
> - pr_warn("%s: Failure %lld clearing "
> - "error injection registers\n",
> - __func__, rc);
This is very minor, but is there a good reason to change the error
message from the one above to the one below? I just hesitate to change
error messages that people might be grepping the source for without a
good reason.
> + if (rc != OPAL_SUCCESS) {
> + pr_warn("%s: Error %lld clearing error injection\n",
> + __func__, rc);
Apart from that this looks good, pending me actually testing it :)
Regards,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20151112/182fc233/attachment.sig>
More information about the Linuxppc-dev
mailing list