[PATCH 1/2] mpc85xx/lbc: modify suspend/resume entry sequence

Dogra Raghav raghav at freescale.com
Tue Nov 3 20:12:31 AEDT 2015



> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, November 03, 2015 1:07 PM
> To: Dogra Raghav-B46184 <raghav at freescale.com>
> Cc: Kushwaha Prabhakar-B32579 <prabhakar at freescale.com>; linuxppc-
> dev at lists.ozlabs.org
> Subject: Re: [PATCH 1/2] mpc85xx/lbc: modify suspend/resume entry
> sequence
> 
> On Tue, 2015-11-03 at 00:33 -0600, Dogra Raghav-B46184 wrote:
> > Hi Scott,
> >
> > I just checked on patchwork and noticed that the original patch has
> > been modified as somehow my original comment has become part of the
> patch:
> > +     if (!lbc)
> > +             goto out;
> >
> >       ctrl->saved_regs = kmalloc(sizeof(struct fsl_lbc_regs), GFP_KERNEL);
> >       if (!ctrl->saved_regs)
> >               return -ENOMEM;
> > [Dogra Raghav-B46184] This is the existing upstream code. Are you
> > suggesting to modify the upstream code to take care of individual
> registers?
> >
> >       _memcpy_fromio(ctrl->saved_regs, lbc, sizeof(struct
> > fsl_lbc_regs));
> > +
> > The patchwork is also showing two links for the patch. Please apply
> > the original patch present at:
> > https://patchwork.ozlabs.org/patch/538605/
> >
> > I will look into how this happened to avoid such incidents in future.
> 
> Your reply looked like a new patch, so Patchwork treated it as such.  If you fix
> your mailer to use proper quote markers (the > at the beginning of each
> line) then this won't happen.
> 
> -Scott

Ok, sorted.

-Raghav


More information about the Linuxppc-dev mailing list