[PATCH] i2c: powermac: don't workaround for keywest

Dan DeVoto dand1972 at yahoo.com
Sun May 17 18:40:07 AEST 2015


Hi,

Sorry for the delay, I found this message in my spam folder.  Anyway,
for my machine model, cat /proc/device-tree/compatible returns:

PowerBook4,3MacRISC2MacRISCPower Macintosh

It's a 14 in. iBook G3 700 MHz.

Regards,

Dan

--------------------------------------------
On Mon, 5/11/15, Benjamin Herrenschmidt <benh at kernel.crashing.org> wrote:

Subject: Re: [PATCH] i2c: powermac: don't workaround for keywest
To: wsa at the-dreams.de
Cc: linux-i2c at vger.kernel.org, linuxppc-dev at lists.ozlabs.org, "Dan DeVoto" <dand1972 at yahoo.com>, "Mark Elliott" <txlitebeer at gmail.com>
Date: Monday, May 11, 2015, 4:26 PM

On Mon, 2015-05-11 at 09:34 +0200, wsa at the-dreams.de wrote:
> On Mon, May 11, 2015 at 08:14:47AM +1000, Benjamin Herrenschmidt wrote:
> > On Sun, 2015-05-10 at 20:34 +0200, Wolfram Sang wrote:
> > > Okay, so this patch is bogus. I understand now that onyx uses another
> > > codec than TAS, so this change will regress on other machines.
> > > However,
> > > it shows that this unconditional instantiation of the TAS breaks sound
> > > on Macintoshs which still need non-aoa sound support. I assume there
> > > will be noone in the near future to convert Keywest to AOA, so we'll
> > > need to find a hackish way around this instantiation problem.
> >

> > Converting the old macs that use TAS shouldn't be *that* hard, main
> > problem is I don't have the hardware to test...
> > Dan and Mark (on CC) have been very helpful with testing. Maybe they are
> > also in to test "the proper solution"?

> Possibly, depends how many machines we can cover. I also have extremely
> little time, so I'm not that keen on volunteering :-) I'll *try* to have
> a look some time this or next week.
>
> The main problem is the difference in the way the layout of the codec
> etc... is reported from the DT by the firmware. Otherwise the HW is the
> same between pre-AOA and post-AOA really ...
>
> I do have a bunch of DT snapshots lying around, so I can try
> to figure out something.
>
> Dan, Mark, what machine models specifically do you have ? (compatible
> property in the DT pls, ie, /proc/device-tree/compatible).
>
> Cheers,
> Ben.
 
 
 


More information about the Linuxppc-dev mailing list