[PATCH] iommu/fsl: Fix the dependency check for PAMU driver.

Varun Sethi Varun.Sethi at freescale.com
Fri May 15 04:17:23 AEST 2015


Hi Scott,

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, May 14, 2015 11:43 PM
> To: Sethi Varun-B16395
> Cc: linuxppc-dev at lists.ozlabs.org; jroedel at suse.de; joro at 8bytes.org;
> iommu at lists.linux-foundation.org
> Subject: Re: [PATCH] iommu/fsl: Fix the dependency check for PAMU driver.
> 
> On Thu, 2015-05-14 at 23:11 +0530, Varun Sethi wrote:
> > Fix the build dependency for the PAMU driver. PPC32 build dependecy is
> incorrect.
> > Add the CORENET_GENERIC build dependency for PAMU driver.
> >
> > Signed-off-by: Varun Sethi <Varun.Sethi at freescale.com>
> > ---
> >  drivers/iommu/Kconfig |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig index
> > 1ae4e54..4ace8db 100644
> > --- a/drivers/iommu/Kconfig
> > +++ b/drivers/iommu/Kconfig
> > @@ -50,7 +50,7 @@ config OF_IOMMU
> >
> >  config FSL_PAMU
> >  	bool "Freescale IOMMU support"
> > -	depends on PPC32
> > +	depends on CORENET_GENERIC
> >  	depends on PPC_E500MC || COMPILE_TEST
> >  	select IOMMU_API
> >  	select GENERIC_ALLOCATOR
> 
> CORENET_GENERIC is for board support.  There is no guarantee that all
> corenet boards will use it.  You already depend on PPC_E500MC; why do you
> need anything else (besides probably getting rid of "|| COMPILE_TEST"
> which is useless if you do add CORENET_GENERIC, because
> CORENET_GENERIC implies PPC_E500MC)?
Yes this is required to counter "||COMPILE_TEST.

-Varun



More information about the Linuxppc-dev mailing list