[PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.

[Suman Tripathi]

On Wed, May 6, 2015 at 2:10 PM, Arnd Bergmann <arnd at arndb.de> wrote:

> On Wednesday 06 May 2015 09:45:15 Michal Simek wrote:
> > On 05/06/2015 09:31 AM, Arnd Bergmann wrote:
> > > On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote:
> > >>>> @@ -533,6 +567,16 @@
> > >>>>                         interrupts = <0x0 0x4f 0x4>;
> > >>>>                 };
> > >>>>
> > >>>> +               sdhc0: sdhc at 1c000000 {
> > >>>> +                       device_type = "sdhc";
> > >>>
> > >>> device_type generally should not be used (there are a few
> exceptions).
> > >>
> > >> Okay !!
> > >>
> > >
> > > While we're at it, please change sdhc at 1c000000 to mmc at 1c000000.
> > > Even though Linux does not care, we try to use the standard device
> > > names for consistency.
> >
> > Do we have a list of these names somewhere?
> > Normally I do use ePARP - generic names recommendation but mmc or sdhci
> > are not listed there.
> > Both combination mmc@ or sdhci@ are used in the kernel.
> >
> > On zynq and zynqmp we do use shdci at .
> >
>
> Ah, I thought ePAPR listed mmc already. Using "sdhci" is a little too
> specific here, since a lot of mmc hosts are not sdhci compliant, and
> "sdhc" is completely wrong, because that identifies a specific card
> type, but a host that supports SDHC cards will generally also work
> with SD (less than 4GB) or SDXC (more than 48GB) cards.
>

Agree on this . Will change it.

>
>         Arnd
>



-- 
Thanks,
with regards,
Suman Tripathi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20150506/25e1f076/attachment.html>