[PATCH v2] powerpc/eeh: Delay probing EEH device during hotplug

Gavin Shan gwshan at linux.vnet.ibm.com
Fri May 1 14:44:20 AEST 2015

Commit ff57b454ddb9 ("powerpc/eeh: Do probe on pci_dn") probes EEH
devices in early stage, which is reasonable to pSeries platform.
However, it's wrong for PowerNV platform because the PE# isn't
determined until the resources (IO and MMIO) are assigned to PE in
hotplug case. So we have to delay probing EEH devices for PowerNV
platform until the PE# is assigned.

Fixes: ff57b454ddb9 ("powerpc/eeh: Do probe on pci_dn")
Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
v2: Corrected commit ID
 arch/powerpc/kernel/eeh.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
index b798c86..04b5d94 100644
--- a/arch/powerpc/kernel/eeh.c
+++ b/arch/powerpc/kernel/eeh.c
@@ -1061,6 +1061,9 @@ void eeh_add_device_early(struct pci_dn *pdn)
 	if (!edev || !eeh_enabled())
+	if (!eeh_has_flag(EEH_PROBE_MODE_DEVTREE))
+		return;
 	/* USB Bus children of PCI devices will not have BUID's */
 	phb = edev->phb;
 	if (NULL == phb ||
@@ -1115,6 +1118,9 @@ void eeh_add_device_late(struct pci_dev *dev)
+	if (eeh_has_flag(EEH_PROBE_MODE_DEV))
+		eeh_ops->probe(pdn, NULL);
 	 * The EEH cache might not be removed correctly because of
 	 * unbalanced kref to the device during unplug time, which

More information about the Linuxppc-dev mailing list