[PATCH] powerpc/pseries: Fix possible leaked device node reference

Michael Ellerman mpe at ellerman.id.au
Fri May 1 09:47:22 AEST 2015

On Thu, 2015-04-30 at 14:58 -0700, Tyrel Datwyler wrote:
> On 04/29/2015 06:44 PM, Nathan Fontenot wrote:
> > Failure return from dlpar_configure_connector when dlpar adding cpus
> > results in leaking references to the cpus parent device node. Move the
> > call to of_node_put() prior to checking the result of
> > dlpar_configure_connector.
> > 
> > Fixes: 8d5ff320766f ("powerpc/pseries: Make dlpar_configure_connector parent node aware")
> That commit went into 3.12. Shouldn't this be CC to stable?

It could, but it fails the "real bug" test:

 - It must fix a real bug that bothers people (not a, "This could be a
   problem..." type thing).

(from Documentation/stable_kernel_rules.txt)

Because the node we're leaking a reference on is /cpus, and in practice that's
pretty harmless.


More information about the Linuxppc-dev mailing list