[PATCH 04/27] powerpc/fsl_pci: Don't change ppc_swiotlb_enable after swiotlb_subsys_init

Daniel Axtens dja at axtens.net
Tue Mar 31 10:57:42 AEDT 2015


> Hmm, I think we got this wrong. I don't remember exactly but it was probably me
> who told you it could be removed, but I probably hadn't had a coffee yet :}
> 
> I see setup_pci_atmu() called by fsl_pci_syscore_do_resume(), ie. at runtime ==
> late. So ignore that.
> 
> But also fsl_add_bridge(), called from fsl_pci_probe(), which is a platform
> driver, registered at arch initcall via fsl_pci_init().
> 
> arch initcall happens *before* subsys, so in that case this will be effective.
> 
> So I think we need to leave it alone.
> 
OK, yeah you're right. Darn.

It looks like we can keep the general approach here, but drop this patch
and the rename patch. Then if we move the swiotlb hooks to the end of
fsl_add_bridge, everything should happen in the right order.

I'll get that into v2.

Thanks for the detailed checking!

-- d

> cheers

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 860 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20150331/cfbdb88a/attachment.sig>


More information about the Linuxppc-dev mailing list