[PATCH] powerpc: Export __spin_yield

Geert Uytterhoeven geert at linux-m68k.org
Mon Mar 30 21:17:37 AEDT 2015


Hi Ben,

On Fri, Mar 20, 2015 at 12:08 AM, Paul Mackerras <paulus at samba.org> wrote:
> On Wed, Feb 25, 2015 at 05:23:53PM -0600, Suresh E. Warrier wrote:
>> Export __spin_yield so that the arch_spin_unlock() function can
>> be invoked from a module. This will be required for modules where
>> we want to take a lock that is also is acquired in hypervisor
>> real mode. Because we want to avoid running any lockdep code
>> (which may not be safe in real mode), this lock needs to be
>> an arch_spinlock_t instead of a normal spinlock.
>>
>> Signed-off-by: Suresh Warrier <warrier at linux.vnet.ibm.com>
>
> Acked-by: Paul Mackerras <paulus at samba.org>

Something went wrong when applying this, as it ended up as:

commit 1f8c82ab1b0bc7e24601c0fca411fd27b9c883ef
Author: Geert Uytterhoeven <geert+renesas at glider.be>
Date:   Wed Mar 4 12:56:20 2015 +0100

    cpufreq/ppc: Add missing #include <asm/smp.h>

    If CONFIG_SMP=n, <linux/smp.h> does not include <asm/smp.h>, causing:

    drivers/cpufreq/ppc-corenet-cpufreq.c: In function 'corenet_cpufreq_cpu_init
    drivers/cpufreq/ppc-corenet-cpufreq.c:173:3: error: implicit declaration of
    X-Patchwork-Id: 443703
    Message-Id: <54EE5989.7010800 at linux.vnet.ibm.com>
    To: linuxppc-dev at ozlabs.org
    Date: Wed, 25 Feb 2015 17:23:53 -0600

    Export __spin_yield so that the arch_spin_unlock() function can
    be invoked from a module. This will be required for modules where
    we want to take a lock that is also is acquired in hypervisor
    real mode. Because we want to avoid running any lockdep code
    (which may not be safe in real mode), this lock needs to be
    an arch_spinlock_t instead of a normal spinlock.

    Signed-off-by: Suresh Warrier <warrier at linux.vnet.ibm.com>
    Acked-by: Paul Mackerras <paulus at samba.org>
    Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds


More information about the Linuxppc-dev mailing list