[RESEND PATCH] For machine check occurring while in guest, KVM layer tries recovery

Paul Mackerras paulus at samba.org
Mon Mar 23 14:32:21 AEDT 2015

On Tue, Mar 17, 2015 at 02:57:48PM +0530, Mahesh J Salgaonkar wrote:
> From: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> and deliver MCE to guest if recovery is failed. For recovered errors
> we just go back to normal functioning of guest. But there are cases
> where we may hit MCE in guest with MSR(RI=0), which means MCE interrupt is
> not recoverable and guest can not function normally it should go down to
> panic path. The current implementation does not have check for MSR(RI=0)
> which can cause guest to crash with Bad kernel stack pointer instead of
> machine check oops message.
> [26281.490060] Bad kernel stack pointer 3fff9ccce5b0 at c00000000000490c
> [26281.490434] Oops: Bad kernel stack pointer, sig: 6 [#1]
> [26281.490472] SMP NR_CPUS=2048 NUMA pSeries
> This patch fixes this issue by checking MSR(RI=0) in KVM layer and forwarding
> unrecoverable interrupt to guest which then panics with proper machine check
> Oops message.
> Signed-off-by: Mahesh Salgaonkar <mahesh at linux.vnet.ibm.com>
> ---
>  arch/powerpc/kvm/book3s_hv_rmhandlers.S |   12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

The patch itself is fine, but you need a proper headline (something
like "KVM: PPC: Book3S HV: Inform guest of unrecoverable machine
checks" perhaps) as the subject of the email, and you need to post the
patch to both the kvm at vger.kernel.org list and the
kvm-ppc at vger.kernel.org list.  Also, the English in the patch
description could use some improvement.

Acked-by: Paul Mackerras <paulus at samba.org>

More information about the Linuxppc-dev mailing list