[PATCH] powerpc: book3e_64: fix the align size for paca_struct

Kevin Hao haokexin at gmail.com
Tue Mar 10 23:21:47 AEDT 2015


On Mon, Mar 09, 2015 at 06:31:25PM +1100, Benjamin Herrenschmidt wrote:
> On Mon, 2015-03-09 at 09:13 +0800, Kevin Hao wrote:
> > On Sun, Mar 08, 2015 at 08:13:26PM +1100, Benjamin Herrenschmidt wrote:
> > > On Sat, 2015-03-07 at 19:14 +0800, Kevin Hao wrote:
> > > > All the cache line size of the current book3e 64bit SoCs are 64 bytes.
> > > > So we should use this size to align the member of paca_struct.
> > > > With this change we save 192 bytes. Also change it to __aligned(size)
> > > > since it is preferred over __attribute__((aligned(size))).
> > > 
> > > Why should we favor the book3e CPUs over the book3s ones ?
> > 
> > Why do you think so? This only change the align size of the paca_struct's
> > members which are private to book3e CPUs, and should not have any effect
> > to book3s ones. Did I miss something?
> 
> No, your explanation was lacking that important detail :-)

Sorry for the confusion, I will add this information in the commit log.

Thanks,
Kevin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20150310/b5f63ae2/attachment.sig>


More information about the Linuxppc-dev mailing list