[PATCH v12 11/21] powerpc/pci: Don't unset PCI resources for VFs
Wei Yang
weiyang at linux.vnet.ibm.com
Mon Mar 2 18:34:45 AEDT 2015
On Tue, Feb 24, 2015 at 02:44:50AM -0600, Bjorn Helgaas wrote:
>On Tue, Feb 24, 2015 at 02:34:13AM -0600, Bjorn Helgaas wrote:
>> From: Wei Yang <weiyang at linux.vnet.ibm.com>
>>
>> If we're going to reassign resources with flag PCI_REASSIGN_ALL_RSRC, all
>> resources will be cleaned out during device header fixup time and then get
>> reassigned by PCI core. However, the VF resources won't be reassigned and
>> thus, we shouldn't clean them out.
>>
>> If the pci_dev is a VF, skip the resource unset process.
>
>I think this patch is correct, but we should include a little more detail
>in the changelog to answer questions like mine and Ben's
>(http://lkml.kernel.org/r/1423528584.4924.70.camel@au1.ibm.com).
>
Ok, I will add more change log to explain this.
>> Signed-off-by: Wei Yang <weiyang at linux.vnet.ibm.com>
>> Signed-off-by: Bjorn Helgaas <bhelgaas at google.com>
>> ---
>> arch/powerpc/kernel/pci-common.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
>> index 2a525c938158..82031011522f 100644
>> --- a/arch/powerpc/kernel/pci-common.c
>> +++ b/arch/powerpc/kernel/pci-common.c
>> @@ -788,6 +788,10 @@ static void pcibios_fixup_resources(struct pci_dev *dev)
>> pci_name(dev));
>> return;
>> }
>> +
>> + if (dev->is_virtfn)
>> + return;
>> +
>> for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
>> struct resource *res = dev->resource + i;
>> struct pci_bus_region reg;
>>
--
Richard Yang
Help you, Help me
More information about the Linuxppc-dev
mailing list