[PATCH v2] powerpc/rcpm: add RCPM driver

[Yuantian Tang]

That makes sense. Thanks for pointing out.

Thanks,
Yuantian

> -----Original Message-----
> From: Paul Bolle [mailto:pebolle at tiscali.nl]
> Sent: Friday, June 12, 2015 4:58 PM
> To: Tang Yuantian-B29983
> Cc: Wood Scott-B07421; linuxppc-dev at lists.ozlabs.org; linux-
> kernel at vger.kernel.org; devicetree at vger.kernel.org; Zhao Chenhui-B35336
> Subject: Re: [PATCH v2] powerpc/rcpm: add RCPM driver
> 
> Just a nit.
> 
> On Thu, 2015-06-11 at 14:32 +0800, Yuantian.Tang at freescale.com wrote:
> > --- /dev/null
> > +++ b/arch/powerpc/sysdev/fsl_rcpm.c
> 
> > +int fsl_rcpm_init(void)
> 
> This is used only through early_initcall(). I took the cargo cult
> approach of looking at the other uses of early_initcall() in
> arch/powerpc/. That approach tells me this function could be static and
> marked as __init. Would that work here too?
> 
> > +{
> > +	[...]
> > +}
> > +
> > +/* need to call this before SMP init */
> > +early_initcall(fsl_rcpm_init);
> 
> Thanks,
> 
> Paul Bolle