[PATCH V8 04/10] powerpc, perf: Re organize PMU based branch filter processing in POWER8

Daniel Axtens dja at axtens.net
Wed Jun 10 15:07:02 AEST 2015


>  	/* Every thing else is unsupported */
>  	return -1;
You're returning -1 as a unsigned 64bit number. Other code that reads
this value tests for -1 and I think it works everywhere just because it
wraps around consistently. But I would still rather not do this and I'm
surprised it doesn't throw a warning.

Regards,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 860 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/linuxppc-dev/attachments/20150610/22a4406c/attachment.sig>


More information about the Linuxppc-dev mailing list