[PATCH] powerpc/eeh-powernv: Fix unbalanced IRQ warning

Alistair Popple alistair at popple.id.au
Thu Jul 30 16:53:54 AEST 2015

pnv_eeh_next_error() re-enables the eeh opal event interrupt but it
gets called from a loop if there are more outstanding events to
process, resulting in a warning due to enabling an already enabled
interrupt. Instead the interrupt should only be re-enabled once the
last outstanding event has been processed.

Tested-by: Daniel Axtens <dja at axtens.net>
Reported-by: Daniel Axtens <dja at axtens.net>
Signed-off-by: Alistair Popple <alistair at popple.id.au>
Acked-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
 arch/powerpc/platforms/powernv/eeh-powernv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/powernv/eeh-powernv.c b/arch/powerpc/platforms/powernv/eeh-powernv.c
index ca825ec..ff41c03 100644
--- a/arch/powerpc/platforms/powernv/eeh-powernv.c
+++ b/arch/powerpc/platforms/powernv/eeh-powernv.c
@@ -1478,7 +1478,7 @@ static int pnv_eeh_next_error(struct eeh_pe **pe)
 	/* Unmask the event */
-	if (eeh_enabled())
+	if (ret == EEH_NEXT_ERR_NONE && eeh_enabled())
 	return ret;

More information about the Linuxppc-dev mailing list