[PATCH] Fix crash due to processing "memory-controller" nodes as "memory"

Michael Ellerman mpe at ellerman.id.au
Tue Jul 21 13:06:24 AEST 2015

On Tue, 2015-07-21 at 12:45 +1000, Anton Blanchard wrote:
> Hi Ian,
> > From: Ian Munsie <imunsie at au1.ibm.com>
> > 
> > If the system has a PCI device with a memory-controller device node,
> > kexec-lite would spew hundreds of double free warnings and eventually
> > segfault. This would result in a "kexec load failed" message from
> > petitboot.
> > 
> > This was due to kexec_memory_map() searching for "memory" nodes, but
> > actually matching any node that started with "memory", including these
> > "memory-controller" nodes. This patch changes the search to look for
> > nodes starting with "memory@", which should only match memory nodes.
> Nice catch! I wonder if we should be checking for device_type
> "memory". Ben?

Yes. That's what Linux does.


More information about the Linuxppc-dev mailing list