[RFC PATCH 04/12] powerpc: Drop unused syscall_get_error()

Michael Ellerman mpe at ellerman.id.au
Wed Jul 15 17:37:06 AEST 2015

syscall_get_error() is unused, and never has been.

It's also probably wrong, as it negates r3 before returning it, but that
depends on what the caller is expecting.

It also doesn't deal with compat, and doesn't deal with TIF_NOERROR.

Although we could fix those, until it has a caller and it's clear what
semantics the caller wants it's just untested code. So drop it.

Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
 arch/powerpc/include/asm/syscall.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/powerpc/include/asm/syscall.h b/arch/powerpc/include/asm/syscall.h
index ff21b7a2f0cc..c6239dabcfb1 100644
--- a/arch/powerpc/include/asm/syscall.h
+++ b/arch/powerpc/include/asm/syscall.h
@@ -34,12 +34,6 @@ static inline void syscall_rollback(struct task_struct *task,
 	regs->gpr[3] = regs->orig_gpr3;
-static inline long syscall_get_error(struct task_struct *task,
-				     struct pt_regs *regs)
-	return (regs->ccr & 0x10000000) ? -regs->gpr[3] : 0;
 static inline long syscall_get_return_value(struct task_struct *task,
 					    struct pt_regs *regs)

More information about the Linuxppc-dev mailing list