[PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available
vgoyal at redhat.com
Wed Jul 15 00:20:04 AEST 2015
On Tue, Jul 14, 2015 at 01:59:19PM +0000, dwalker at fifo99.com wrote:
> On Mon, Jul 13, 2015 at 08:19:45PM -0500, Eric W. Biederman wrote:
> > dwalker at fifo99.com writes:
> > > On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote:
> > >> Hidehiro Kawai <hidehiro.kawai.ez at hitachi.com> writes:
> > >>
> > >> > You can call panic notifiers and kmsg dumpers before kdump by
> > >> > specifying "crash_kexec_post_notifiers" as a boot parameter.
> > >> > However, it doesn't make sense if kdump is not available. In that
> > >> > case, disable "crash_kexec_post_notifiers" boot parameter so that
> > >> > you can't change the value of the parameter.
> > >>
> > >> Nacked-by: "Eric W. Biederman" <ebiederm at xmission.com>
> > >
> > > I think it would make sense if he just replaced "kdump" with "kexec".
> > It would be less insane, however it still makes no sense as without
> > kexec on panic support crash_kexec is a noop. So the value of the
> > seeting makes no difference.
> Can you explain more, I don't really understand what you mean. Are you suggesting
> the whole "crash_kexec_post_notifiers" feature has no value ?
If CONFIG_KEXEC=n, then crash_kexec() is a nop. So it does not matter
whether crash_kexec() is called before panic notifiers or after.
IOW, what do you gain by disabling crash_kexec_post_notifiers, in
case of CONFIG_KEXEC=n?
More information about the Linuxppc-dev