[patch 07/20] powerpc/hlwd-pic: Consolidate chained IRQ handler install/remove

Thomas Gleixner tglx at linutronix.de
Tue Jul 14 06:50:11 AEST 2015


Chained irq handlers usually set up handler data as well. We now have
a function to set both under irq_desc->lock. Replace the two calls
with one.

Search and conversion was done with coccinelle.

Reported-by: Russell King <rmk+kernel at arm.linux.org.uk>
Signed-off-by: Thomas Gleixner <tglx at linutronix.de>
Cc: Julia Lawall <Julia.Lawall at lip6.fr>
Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
Cc: Michael Ellerman <mpe at ellerman.id.au>
Cc: linuxppc-dev at lists.ozlabs.org
---
 arch/powerpc/platforms/embedded6xx/hlwd-pic.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: tip/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
===================================================================
--- tip.orig/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
+++ tip/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
@@ -212,9 +212,9 @@ void hlwd_pic_probe(void)
 			host = hlwd_pic_init(np);
 			BUG_ON(!host);
 			cascade_virq = irq_of_parse_and_map(np, 0);
-			irq_set_handler_data(cascade_virq, host);
-			irq_set_chained_handler(cascade_virq,
-						hlwd_pic_irq_cascade);
+			irq_set_chained_handler_and_data(cascade_virq,
+							 hlwd_pic_irq_cascade,
+							 host);
 			hlwd_irq_host = host;
 			break;
 		}




More information about the Linuxppc-dev mailing list