[PATCH 1/2] powerpc/kexec: Reset secondary cpu endianess before kexec

Paul Mackerras paulus at samba.org
Wed Jul 8 14:04:56 AEST 2015


On Tue, Jul 07, 2015 at 09:35:38PM -0500, Scott Wood wrote:
> 
> Also, it would be better to use label subtraction rather than hardcoding 
> "28", and the bcl instruction would be more readable as "bl <label>".

I agree about using labels, but "bcl 20,31,foo" is not the same thing
as "bl foo".  The former is a form of bl that doesn't perturb the link
stack and is therefore better for performance when you're not going to
do a matching blr later (not that performance is at all critical
here).

Paul.


More information about the Linuxppc-dev mailing list