[PATCH SLOF v3 3/5] disk-label: rename confusing "block" word

Nikunj A Dadhania nikunj at linux.vnet.ibm.com
Thu Jul 2 15:47:49 AEST 2015

Hi Segher,

Segher Boessenkool <segher at kernel.crashing.org> writes:
> On Tue, Jun 30, 2015 at 04:31:19PM +0530, Nikunj A Dadhania wrote:
>> "block" word is not a block number, actually its an allocated host
>> address.  Rename it to disk-buf along with a associated
>> size(disk-buf-size=4096) for using during allocation/free.
>> Also renaming the helper routine read-sector to read-disk-buf. This
>> routine assumes the address to be disk-buf and only takes sector number
>> as argument.
> This isn't what I suggested, and I think it is a terrible idea.

The comment was against the "has-fat-filesystem". As the complete
disk-label.fs had that same assumption, I went ahead and renamed "block"
across the file.

Are you suggesting to drop complete patch or just the rename of
"read-sector" ?

> Just FWIW :-)


More information about the Linuxppc-dev mailing list