[PATCH][v4] power/fsl: add MDIO dt binding for FMan

Shaohui Xie Shaohui.Xie at freescale.com
Fri Jan 30 14:04:03 AEDT 2015


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Friday, January 30, 2015 10:44 AM
> To: Xie Shaohui-B21989
> Cc: linuxppc-dev at lists.ozlabs.org; devicetree at vger.kernel.org; Medve
> Emilian-EMMEDVE1
> Subject: Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan
> 
> On Thu, 2015-01-29 at 20:38 -0600, Xie Shaohui-B21989 wrote:
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Friday, January 30, 2015 8:54 AM
> > > To: shh.xie at gmail.com
> > > Cc: linuxppc-dev at lists.ozlabs.org; devicetree at vger.kernel.org; Medve
> > > Emilian-EMMEDVE1; Xie Shaohui-B21989
> > > Subject: Re: [PATCH][v4] power/fsl: add MDIO dt binding for FMan
> > >
> > > On Wed, 2015-01-28 at 19:54 +0800, shh.xie at gmail.com wrote:
> > > > +- interrupts
> > > > +		Usage: required
> > > > +		Value type: <prop-encoded-array>
> > > > +		Definition: Event interrupt of external MDIO controller.
> > >
> > > What if this MDIO controller is not "external"?  Should Usage say
> > > "required for external MDIO"?
> > [S.H] I thought the definition can tell the interrupt is for external
> > MDIO, I can change the Usage to "required for external MDIO" in next
> version.
> > how about other parts, are they OK?
> 
> Yes.  I'll fix it up when applying.

Thank you!

Shaohui



More information about the Linuxppc-dev mailing list